Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: Do not increase error counter if the pilorama is disabled #1642

Merged
merged 1 commit into from
Jul 30, 2022

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Jul 30, 2022

After a4adb79 new logical error could be returned. Do not increase
error counter in this case.

Signed-off-by: Evgenii Stratonikov evgeniy@morphbits.ru

@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Merging #1642 (a5296f6) into master (4abe5a7) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1642      +/-   ##
==========================================
- Coverage   33.30%   33.17%   -0.14%     
==========================================
  Files         331      332       +1     
  Lines       22595    22714     +119     
==========================================
+ Hits         7526     7536      +10     
- Misses      14451    14560     +109     
  Partials      618      618              
Impacted Files Coverage Δ
pkg/local_object_storage/engine/tree.go 0.00% <0.00%> (ø)
...d/neofs-adm/internal/modules/morph/local_client.go 0.00% <0.00%> (ø)
...fs-adm/internal/modules/morph/initialize_deploy.go 0.00% <0.00%> (ø)
cmd/neofs-adm/internal/modules/morph/deploy.go 9.27% <0.00%> (ø)
cmd/neofs-adm/internal/modules/morph/root.go 49.30% <0.00%> (+0.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

…a is disabled

After a4adb79 new logical error could be returned. Do not increase
error counter in this case.

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
@fyrchik fyrchik merged commit 8ffc2fd into nspcc-dev:master Jul 30, 2022
@alexchetaev alexchetaev added the U3 Regular label Aug 23, 2022
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
…a is disabled

After a4adb79 new logical error could be returned. Do not increase
error counter in this case.

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working U3 Regular
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants