innerring: exit if we cannot bind to the control endpoint #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1643 +/- ##
=========================================
Coverage ? 33.18%
=========================================
Files ? 332
Lines ? 22706
Branches ? 0
=========================================
Hits ? 7536
Misses ? 14552
Partials ? 618 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Does that bug also mean that if we somehow got some errors almost simultaneously, we won't stop the app due to the unbuffered err channel? |
KirillovDenis
previously approved these changes
Aug 4, 2022
realloc
previously approved these changes
Aug 4, 2022
carpawell
previously approved these changes
Aug 4, 2022
…point Return listen errors in a synchronous fashion. Another solution would be to use buffered channel, but this is not scalable: for each new similar runner we would need to extend the buffer. Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
carpawell
dismissed stale reviews from realloc, KirillovDenis, and themself
via
d91566b
carpawell
force-pushed
the
fix-innerring
branch
from
a2027c3
to
d91566b
Compare
carpawell
approved these changes
Aug 4, 2022
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
…point Return listen errors in a synchronous fashion. Another solution would be to use buffered channel, but this is not scalable: for each new similar runner we would need to extend the buffer. Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1641 .
Return listen errors in a synchronous fashion.
Another solution would be to use buffered channel, but this is not
scalable: for each new similar runner we would need to extend the
buffer.
Signed-off-by: Evgenii Stratonikov evgeniy@morphbits.ru