Fix/Handle chain notifications via pool #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handling notification in a synchronous manner may lead to a blocking state if a handler uses neo-go client. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Codecov Report
@@ Coverage Diff @@
## master #1653 +/- ##
==========================================
- Coverage 33.18% 33.13% -0.05%
==========================================
Files 332 332
Lines 22706 22707 +1
==========================================
- Hits 7536 7525 -11
- Misses 14552 14564 +12
Partials 618 618
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
KirillovDenis
previously approved these changes
Aug 4, 2022
|
Fix commit message please |
|
@KirillovDenis, wrong push. The second commit should be merged via #1656. Fixed. |
cthulhu-rider
approved these changes
Aug 4, 2022
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
Handling notification in a synchronous manner may lead to a blocking state if a handler uses neo-go client. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1577. Fixes node freezing but does not affect the problem with a call timeout.