Fix/Do not print false warning about deprecated config #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1654 +/- ##
==========================================
- Coverage 33.18% 33.17% -0.02%
==========================================
Files 332 332
Lines 22706 22714 +8
==========================================
Hits 7536 7536
- Misses 14552 14560 +8
Partials 618 618
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
fyrchik
reviewed
Aug 4, 2022
cmd/neofs-ir/main.go
Outdated
| } | ||
|
|
||
| if timeout == 0 { | ||
| timeout = time.Second * defaultTimeout |
There was a problem hiding this comment.
Why not make defaultTimeout * time.Second the constant itself?
cmd/neofs-ir/defaults.go
Outdated
Comment on lines
40
to
42
| cfg.SetDefault("profiler.address", "localhost:6060") | ||
| cfg.SetDefault("profiler.shutdown_timeout", "30s") | ||
|
|
||
| cfg.SetDefault("metrics.address", "localhost:9090") |
There was a problem hiding this comment.
This used the old values because of the need to support both sections.
I think we can remove already deprecated sections in the next release and simplify the code considerably.
…tions Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
|
@fyrchik, changed the idea of the PR: just dropped the deprecated naming. |
KirillovDenis
approved these changes
Aug 4, 2022
realloc
approved these changes
Aug 4, 2022
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
…onfig sections Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.