Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance mode improvements #1840

Merged
merged 5 commits into from
Oct 10, 2022
Merged

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Oct 5, 2022

  1. Allow to specify mode: disabled in the configuration.
  2. Use blobstor paths as an identifier for a shard.

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #1840 (22e69f9) into master (b2aa994) will decrease coverage by 0.07%.
The diff coverage is 40.59%.

❗ Current head 22e69f9 differs from pull request most recent head a4bc317. Consider uploading reports for the commit a4bc317 to get more accurate results

@@            Coverage Diff             @@
##           master    #1840      +/-   ##
==========================================
- Coverage   31.32%   31.24%   -0.08%     
==========================================
  Files         374      375       +1     
  Lines       26495    26510      +15     
==========================================
- Hits         8300     8284      -16     
- Misses      17507    17535      +28     
- Partials      688      691       +3     
Impacted Files Coverage Δ
cmd/neofs-node/config.go 0.00% <0.00%> (ø)
pkg/local_object_storage/blobstor/blobstor.go 79.16% <ø> (ø)
pkg/local_object_storage/blobstor/info.go 0.00% <0.00%> (ø)
pkg/services/control/types.go 75.51% <ø> (-0.97%) ⬇️
pkg/services/control/types.pb.go 30.46% <16.27%> (-2.88%) ⬇️
cmd/neofs-node/config/engine/config.go 86.20% <60.00%> (-5.80%) ⬇️
pkg/services/control/types_neofs.pb.go 69.00% <76.47%> (+0.76%) ⬆️
pkg/local_object_storage/engine/control.go 71.85% <93.33%> (+1.08%) ⬆️
...ct_storage/blobstor/blobovniczatree/blobovnicza.go 64.19% <100.00%> (+3.43%) ⬆️
pkg/local_object_storage/blobstor/fstree/fstree.go 68.39% <100.00%> (+1.53%) ⬆️
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

acid-ant
acid-ant previously approved these changes Oct 6, 2022
cthulhu-rider
cthulhu-rider previously approved these changes Oct 7, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
Currently, when removing shard special care must be taken with respect
to shard numbering. `mode: disabled` allows to leave shard configuration
in place while also ignoring it during initialization. This makes
disk replacement much more convenient.

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
@fyrchik fyrchik merged commit 2d43892 into nspcc-dev:master Oct 10, 2022
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
Currently, when removing shard special care must be taken with respect
to shard numbering. `mode: disabled` allows to leave shard configuration
in place while also ignoring it during initialization. This makes
disk replacement much more convenient.

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality neofs-storage Storage node application issues U2 Seriously planned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants