Make metabase.ContainerSize actually read-only
#1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the `Bucket.ForEach` doc: ``` The provided function must not modify the bucket; this will result in undefined behavior. ``` Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Codecov Report
@@ Coverage Diff @@
## master #1975 +/- ##
==========================================
- Coverage 30.50% 30.50% -0.01%
==========================================
Files 379 379
Lines 27705 27714 +9
==========================================
+ Hits 8452 8453 +1
- Misses 18557 18569 +12
+ Partials 696 692 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| if err != nil { | ||
| return fmt.Errorf("create global bucket for locked objects: %w", err) | ||
| } | ||
| bucketLocked := tx.Bucket(bucketNameLocked) |
There was a problem hiding this comment.
Maybe throw clear panic in this case instead of NPE?
There was a problem hiding this comment.
It is like this in many places and is not expected to happen.
cthulhu-rider
approved these changes
Oct 26, 2022
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1944.
Close #1974.