Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SUPPORT] Fix/Write-cache flush duplication #2074

Merged
merged 2 commits into from
Nov 18, 2022
Merged

[SUPPORT] Fix/Write-cache flush duplication #2074

merged 2 commits into from
Nov 18, 2022

Conversation

carpawell
Copy link
Member

@carpawell carpawell commented Nov 17, 2022 •
edited
Loading

Fixes

Nov 03 08:10:25 vedi neofs-node[606]: 2022-11-03T08:10:25.933Z        debug        writecache/flush.go:121        tried to flush items from write-cache        {"shard_id": "Q4JVDpjCDxx5as5HYzRdyZ", "count": 1, "start": ""}
Nov 03 08:10:25 vedi neofs-node[606]: 2022-11-03T08:10:25.933Z        debug        writecache/flush.go:121        tried to flush items from write-cache        {"shard_id": "Q4JVDpjCDxx5as5HYzRdyZ", "count": 1, "start": ""}
Nov 03 08:10:25 vedi neofs-node[606]: 2022-11-03T08:10:25.933Z        debug        writecache/flush.go:121        tried to flush items from write-cache        {"shard_id": "Q4JVDpjCDxx5as5HYzRdyZ", "count": 1, "start": ""}
Nov 03 08:10:25 vedi neofs-node[606]: 2022-11-03T08:10:25.933Z        debug        writecache/flush.go:121        tried to flush items from write-cache        {"shard_id": "Q4JVDpjCDxx5as5HYzRdyZ", "count": 1, "start": ""}
Nov 03 08:10:25 vedi neofs-node[606]: 2022-11-03T08:10:25.933Z        debug        writecache/flush.go:121        tried to flush items from write-cache        {"shard_id": "Q4JVDpjCDxx5as5HYzRdyZ", "count": 1, "start": ""}
Nov 03 08:10:25 vedi neofs-node[606]: 2022-11-03T08:10:25.933Z        debug        writecache/flush.go:121        tried to flush items from write-cache        {"shard_id": "Q4JVDpjCDxx5as5HYzRdyZ", "count": 1, "start": ""}
Nov 03 08:10:25 vedi neofs-node[606]: 2022-11-03T08:10:25.933Z        debug        writecache/flush.go:121        tried to flush items from write-cache        {"shard_id": "Q4JVDpjCDxx5as5HYzRdyZ", "count": 1, "start": ""}
Nov 03 08:10:25 vedi neofs-node[606]: 2022-11-03T08:10:25.934Z        debug        writecache/flush.go:121        tried to flush items from write-cache        {"shard_id": "Q4JVDpjCDxx5as5HYzRdyZ", "count": 1, "start": ""}
Nov 03 08:10:25 vedi neofs-node[606]: 2022-11-03T08:10:25.934Z        debug        writecache/flush.go:121        tried to flush items from write-cache        {"shard_id": "Q4JVDpjCDxx5as5HYzRdyZ", "count": 1, "start": ""}
Nov 03 08:10:25 vedi neofs-node[606]: 2022-11-03T08:10:25.934Z        debug        writecache/flush.go:121        tried to flush items from write-cache        {"shard_id": "Q4JVDpjCDxx5as5HYzRdyZ", "count": 1, "start": ""}
Nov 03 08:10:25 vedi neofs-node[606]: 2022-11-03T08:10:25.934Z        debug        writecache/flush.go:121        tried to flush items from write-cache        {"shard_id": "Q4JVDpjCDxx5as5HYzRdyZ", "count": 1, "start": ""}
Nov 03 08:10:25 vedi neofs-node[606]: 2022-11-03T08:10:25.946Z        info        log/log.go:13        local object storage operation        {"shard_id": "Q4JVDpjCDxx5as5HYzRdyZ", "address": "7QwoRQ8cW63GRyT5DZJbXcpkBhyaCHsPsUBvV6PGQAHt/HRCKtbDHaVXcb51F3vde89fFw99E9VfZXoWd8zdTeGCu", "op": "PUT", "type": "blobovnicza", "storage_id": "3/0"}
Nov 03 08:10:25 vedi neofs-node[606]: 2022-11-03T08:10:25.946Z        info        log/log.go:13        local object storage operation        {"shard_id": "Q4JVDpjCDxx5as5HYzRdyZ", "address": "7QwoRQ8cW63GRyT5DZJbXcpkBhyaCHsPsUBvV6PGQAHt/HRCKtbDHaVXcb51F3vde89fFw99E9VfZXoWd8zdTeGCu", "op": "PUT", "type": "blobovnicza", "storage_id": "3/0"}
Nov 03 08:10:25 vedi neofs-node[606]: 2022-11-03T08:10:25.946Z        info        log/log.go:13        local object storage operation        {"shard_id": "Q4JVDpjCDxx5as5HYzRdyZ", "address": "7QwoRQ8cW63GRyT5DZJbXcpkBhyaCHsPsUBvV6PGQAHt/HRCKtbDHaVXcb51F3vde89fFw99E9VfZXoWd8zdTeGCu", "op": "PUT", "type": "blobovnicza", "storage_id": "3/0"}
Nov 03 08:10:25 vedi neofs-node[606]: 2022-11-03T08:10:25.946Z        info        log/log.go:13        local object storage operation        {"shard_id": "Q4JVDpjCDxx5as5HYzRdyZ", "address": "7QwoRQ8cW63GRyT5DZJbXcpkBhyaCHsPsUBvV6PGQAHt/HRCKtbDHaVXcb51F3vde89fFw99E9VfZXoWd8zdTeGCu", "op": "PUT", "type": "blobovnicza", "storage_id": "3/0"}
Nov 03 08:10:25 vedi neofs-node[606]: 2022-11-03T08:10:25.946Z        info        log/log.go:13        local object storage operation        {"shard_id": "Q4JVDpjCDxx5as5HYzRdyZ", "address": "7QwoRQ8cW63GRyT5DZJbXcpkBhyaCHsPsUBvV6PGQAHt/HRCKtbDHaVXcb51F3vde89fFw99E9VfZXoWd8zdTeGCu", "op": "PUT", "type": "blobovnicza", "storage_id": "3/0"}
Nov 03 08:10:25 vedi neofs-node[606]: 2022-11-03T08:10:25.946Z        info        log/log.go:13        local object storage operation        {"shard_id": "Q4JVDpjCDxx5as5HYzRdyZ", "address": "7QwoRQ8cW63GRyT5DZJbXcpkBhyaCHsPsUBvV6PGQAHt/HRCKtbDHaVXcb51F3vde89fFw99E9VfZXoWd8zdTeGCu", "op": "PUT", "type": "blobovnicza", "storage_id": "3/0"}
Nov 03 08:10:25 vedi neofs-node[606]: 2022-11-03T08:10:25.946Z        info        log/log.go:13        local object storage operation        {"shard_id": "Q4JVDpjCDxx5as5HYzRdyZ", "address": "7QwoRQ8cW63GRyT5DZJbXcpkBhyaCHsPsUBvV6PGQAHt/HRCKtbDHaVXcb51F3vde89fFw99E9VfZXoWd8zdTeGCu", "op": "PUT", "type": "blobovnicza", "storage_id": "3/0"}
Nov 03 08:10:25 vedi neofs-node[606]: 2022-11-03T08:10:25.947Z        info        log/log.go:13        local object storage operation        {"shard_id": "Q4JVDpjCDxx5as5HYzRdyZ", "address": "7QwoRQ8cW63GRyT5DZJbXcpkBhyaCHsPsUBvV6PGQAHt/HRCKtbDHaVXcb51F3vde89fFw99E9VfZXoWd8zdTeGCu", "op": "PUT", "type": "blobovnicza", "storage_id": "3/0"}
Nov 03 08:10:25 vedi neofs-node[606]: 2022-11-03T08:10:25.947Z        info        log/log.go:13        local object storage operation        {"shard_id": "Q4JVDpjCDxx5as5HYzRdyZ", "address": "7QwoRQ8cW63GRyT5DZJbXcpkBhyaCHsPsUBvV6PGQAHt/HRCKtbDHaVXcb51F3vde89fFw99E9VfZXoWd8zdTeGCu", "op": "PUT", "type": "blobovnicza", "storage_id": "3/0"}
Nov 03 08:10:25 vedi neofs-node[606]: 2022-11-03T08:10:25.947Z        info        log/log.go:13        local object storage operation        {"shard_id": "Q4JVDpjCDxx5as5HYzRdyZ", "address": "7QwoRQ8cW63GRyT5DZJbXcpkBhyaCHsPsUBvV6PGQAHt/HRCKtbDHaVXcb51F3vde89fFw99E9VfZXoWd8zdTeGCu", "op": "PUT", "type": "blobovnicza", "storage_id": "3/0"}
Nov 03 08:10:25 vedi neofs-node[606]: 2022-11-03T08:10:25.947Z        info        log/log.go:13        local object storage operation        {"shard_id": "Q4JVDpjCDxx5as5HYzRdyZ", "address": "7QwoRQ8cW63GRyT5DZJbXcpkBhyaCHsPsUBvV6PGQAHt/HRCKtbDHaVXcb51F3vde89fFw99E9VfZXoWd8zdTeGCu", "op": "PUT", "type": "blobovnicza", "storage_id": "3/0"}
Nov 03 08:10:25 vedi neofs-node[606]: 2022-11-03T08:10:25.947Z        info        log/log.go:13        local object storage operation        {"shard_id": "Q4JVDpjCDxx5as5HYzRdyZ", "address": "7QwoRQ8cW63GRyT5DZJbXcpkBhyaCHsPsUBvV6PGQAHt/HRCKtbDHaVXcb51F3vde89fFw99E9VfZXoWd8zdTeGCu", "op": "PUT", "type": "blobovnicza", "storage_id": "3/0"}

@carpawell carpawell added bug Something isn't working neofs-storage Storage node application issues labels Nov 17, 2022
@carpawell carpawell self-assigned this Nov 17, 2022
@carpawell
[#2074] write-cache: Remove unused variables
a98a154 
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@sami-nspcc
Copy link

I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing.

1 similar comment
@sami-nspcc
Copy link

I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing.

@carpawell
[#2074] write-cache: Do not flush same object twice
0c3247d 
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell carpawell marked this pull request as ready for review November 17, 2022 16:49
@sami-nspcc
Copy link

I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing.

@sami-nspcc
Copy link

I am running integration tests

1 similar comment
@sami-nspcc
Copy link

I am running integration tests

@codecov
Copy link

codecov bot commented Nov 17, 2022 •
edited
Loading

Codecov Report

Merging #2074 (0c3247d) into support/v0.34 (15d2091) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@                Coverage Diff                @@
##           support/v0.34    #2074      +/-   ##
=================================================
- Coverage          30.67%   30.66%   -0.01%     
=================================================
  Files                380      380              
  Lines              28071    28080       +9     
=================================================
  Hits                8610     8610              
- Misses             18722    18731       +9     
  Partials             739      739
Impacted Files Coverage Δ
pkg/local_object_storage/writecache/flush.go 57.22% <0.00%> (-3.02%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sami-nspcc
Copy link

I am running integration tests

@sami-nspcc
Copy link

Test run is finished. Please download the tarball from st*.t5.fs.neo.org: FszwwAx3VznDysQGxBUMRj1zj3zp8VcohorVDnunrviV/39P2X6AgjkRpPzpE5ARG1SYfPTDNG1RSfKz19KuyXXNs Untar and use allure open to watch the report

@sami-nspcc
Copy link

Test run is finished. Please download the tarball from st*.t5.fs.neo.org: FszwwAx3VznDysQGxBUMRj1zj3zp8VcohorVDnunrviV/G8Vhy4owx7dTDkpg9Q6k5EHGjXTzHufAKyY1KnKFmXp Untar and use allure open to watch the report

@sami-nspcc
Copy link

Test run is finished. Please download the tarball from st*.t5.fs.neo.org: FszwwAx3VznDysQGxBUMRj1zj3zp8VcohorVDnunrviV/ATVZUwH5YSeh4crGWvE4eYaDi2W96CdgDuvDoJH89Ek5 Untar and use allure open to watch the report

@alexchetaev alexchetaev added the U3 Regular label Nov 17, 2022
@fyrchik fyrchik merged commit 584f465 into nspcc-dev:support/v0.34 Nov 18, 2022
@carpawell carpawell deleted the fix/writecache-flush-duplication branch November 18, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fyrchik fyrchik fyrchik approved these changes

@acid-ant acid-ant acid-ant approved these changes

@alexvanin alexvanin Awaiting requested review from alexvanin

@cthulhu-rider cthulhu-rider Awaiting requested review from cthulhu-rider

Assignees

@fyrchik fyrchik

@carpawell carpawell

Labels
bug Something isn't working neofs-storage Storage node application issues U3 Regular
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@carpawell @sami-nspcc @fyrchik @acid-ant @alexchetaev