-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
morph/client: Ignore error if a transaction already exists #2075
morph/client: Ignore error if a transaction already exists #2075
Conversation
I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing. |
1 similar comment
I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing. |
I am running integration tests |
Codecov Report
@@ Coverage Diff @@
## support/v0.34 #2075 +/- ##
=================================================
- Coverage 30.66% 30.65% -0.01%
=================================================
Files 380 380
Lines 28080 28087 +7
=================================================
Hits 8610 8610
- Misses 18731 18738 +7
Partials 739 739
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I am running integration tests |
…exists Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing. |
Test run is finished. Please download the tarball from |
c.logger.Debug("notary deposit has already been made", | ||
zap.Int64("amount", int64(amount)), | ||
zap.Int64("expire_at", till), | ||
zap.Uint32("vub", vub), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest one of:
- "vub" -> "valid_until_block" if we try to be more friendly for a user
- "expire_at" -> "till" if we want to save the original
neo-go
context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have copied it from the line below, let's be consistent here.
Test run is finished. Please download the tarball from |
Signed-off-by: Evgenii Stratonikov evgeniy@morphbits.ru