Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

morph/client: Ignore error if a transaction already exists #2075

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Nov 18, 2022

Signed-off-by: Evgenii Stratonikov evgeniy@morphbits.ru

@sami-nspcc
Copy link

I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing.

1 similar comment
@sami-nspcc
Copy link

I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing.

@sami-nspcc
Copy link

I am running integration tests

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #2075 (d4bd1f9) into support/v0.34 (584f465) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@                Coverage Diff                @@
##           support/v0.34    #2075      +/-   ##
=================================================
- Coverage          30.66%   30.65%   -0.01%     
=================================================
  Files                380      380              
  Lines              28080    28087       +7     
=================================================
  Hits                8610     8610              
- Misses             18731    18738       +7     
  Partials             739      739              
Impacted Files Coverage Δ
pkg/morph/client/notary.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sami-nspcc
Copy link

I am running integration tests

…exists

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
@sami-nspcc
Copy link

I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing.

@sami-nspcc
Copy link

Test run is finished. Please download the tarball from st*.t5.fs.neo.org: FszwwAx3VznDysQGxBUMRj1zj3zp8VcohorVDnunrviV/BQQBdewRsHgoD1suUwpriQm5L7wwfEpTSESVWr27XxQy Untar and use allure open to watch the report

c.logger.Debug("notary deposit has already been made",
zap.Int64("amount", int64(amount)),
zap.Int64("expire_at", till),
zap.Uint32("vub", vub),
Copy link
Member

@carpawell carpawell Nov 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest one of:

  1. "vub" -> "valid_until_block" if we try to be more friendly for a user
  2. "expire_at" -> "till" if we want to save the original neo-go context

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have copied it from the line below, let's be consistent here.

@fyrchik fyrchik merged commit 02049ca into nspcc-dev:support/v0.34 Nov 18, 2022
@sami-nspcc
Copy link

Test run is finished. Please download the tarball from st*.t5.fs.neo.org: FszwwAx3VznDysQGxBUMRj1zj3zp8VcohorVDnunrviV/3j3s6yKjNoKQdum1bfFycyQ7ThRz7abeiRyBKGjp6EGH Untar and use allure open to watch the report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants