neofs-node: Reload config for pprof and metrics on SIGHUP #2094
Conversation
|
I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing. Build number is 3705 |
Codecov Report
@@ Coverage Diff @@
## master #2094 +/- ##
==========================================
- Coverage 30.71% 30.70% -0.02%
==========================================
Files 383 382 -1
Lines 28277 28121 -156
==========================================
- Hits 8685 8634 -51
+ Misses 18862 18754 -108
- Partials 730 733 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
is it possible to provide some sort of a dynamic configuration to our http servers the same way it is done for logger? at least that is how i planned SIGHUP unification
|
I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing. Build number is 3751 |
|
I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing. Build number is 3766 |
|
I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing. Build number is 3767 |
|
I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing. Build number is 3768 |
|
I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing. Build number is 3769 |
|
I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing. Build number is 3772 |
|
I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing. Build number is 3778 |
|
Current behavior for metrics:
|
| func delCloser(c *cfg, name string) { | ||
| for i, clsr := range c.closers { | ||
| if clsr.name == name { | ||
| c.closers[i] = c.closers[len(c.closers)-1] |
There was a problem hiding this comment.
can't say for sure but think that we can rely on the closers' order now or in the future. not sure
There was a problem hiding this comment.
It is a simplest way to detect do we have closer/worker for the httpcomponent or not. In other case we need to remember id for worker and closer and do not forget to set it to negative value to mark that closer/worker for component deleted or not initialized at that moment, and do not forget to check this when reloading, and at the end when removing closer/worker for pprof we need to decrement index for metrics and the same for metrics. We have less than 20 workers\closers currently to iterate over. You prefer this approach?
|
Changelog conflicts. |
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
Close #1868
Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com