Fix/OID signature in CLI output #2104
Conversation
carpawell
added
bug
|
I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing. Build number is 3716 |
|
I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing. Build number is 3717 |
carpawell
requested review from
alexvanin,
fyrchik and
cthulhu-rider
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2104 +/- ##
=======================================
Coverage 30.61% 30.61%
=======================================
Files 380 380
Lines 28130 28130
=======================================
Hits 8613 8613
Misses 18778 18778
Partials 739 739 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I am running integration tests |
|
I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing. Build number is 3718 |
cmd/neofs-cli/modules/object/head.go
Outdated
| if signature := obj.Signature(); signature != nil { | ||
| cmd.Print("ID signature:\n") | ||
|
|
||
| // TODO(@cthulhu-rider): #1387 implement and use another approach to avoid conversion |
There was a problem hiding this comment.
Let's use @carpawell here.
There was a problem hiding this comment.
well, in fact, i have no idea what is it about, i just moved that from one place to another
but ok, changed that
|
Test run is finished. Please download the tarball from link. Untar and use |
|
I am running integration tests |
|
I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing. Build number is 3719 |
|
Test run is finished. Please download the tarball from link. Untar and use |
|
I am running integration tests |
OID signature should always be present in an object; it does not relate to the object split. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
|
I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing. Build number is 3720 |
|
Test run is finished. Please download the tarball from link. Untar and use |
|
I am running integration tests |
|
Test run is finished. Please download the tarball from link. Untar and use |
OID signature should always be present in an object; it does not relate to the object split.
Signed-off-by: Pavel Karpy carpawell@nspcc.ru
It is about the field.