Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/tree: close connection after the syncronization #2162

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Dec 16, 2022

There was a goroutine leak here.

No need to test.

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

…tion

There was a goroutine leak here.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Copy link
Member

@carpawell carpawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #2162 (0f9c37a) into master (8126c79) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2162      +/-   ##
==========================================
- Coverage   30.76%   30.76%   -0.01%     
==========================================
  Files         382      382              
  Lines       28094    28095       +1     
==========================================
  Hits         8644     8644              
- Misses      18716    18717       +1     
  Partials      734      734              
Impacted Files Coverage Δ
pkg/services/tree/sync.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fyrchik fyrchik merged commit dcdf27b into nspcc-dev:master Dec 16, 2022
@alexchetaev alexchetaev added U3 Regular U2 Seriously planned and removed U3 Regular labels Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working U2 Seriously planned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants