adm: use native neo-go sessions in dump-hashes
#2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## support/v0.35 #2224 +/- ##
=================================================
- Coverage 30.89% 30.87% -0.03%
=================================================
Files 383 383
Lines 28365 28387 +22
=================================================
Hits 8764 8764
- Misses 18854 18876 +22
Partials 747 747
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roman-khimov
previously approved these changes
Jan 30, 2023
| } | ||
|
|
||
| if !bytes.HasSuffix(bs, []byte(zone)) { | ||
| continue | ||
| return |
There was a problem hiding this comment.
roman-khimov
previously approved these changes
Jan 30, 2023
carpawell
previously approved these changes
Jan 31, 2023
acid-ant
previously approved these changes
Jan 31, 2023
If we had lots of domains in one zone, `dump-hashes` for all others can miss some domains, because we need to restrict ourselves with _some_ number. In this commit we use neo-go sessions by default, with a proper failback to in-script iterator unwrapping. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we had lots of domains in one zone,
dump-hashesfor all others can miss some domains, because we need to restrict ourselves with some number.In this commit we use neo-go sessions by default, with a proper failback to in-script iterator unwrapping.
Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com