Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/util: Fix basic ACL rendering #2259

Merged

Conversation

cthulhu-rider
Copy link
Contributor

@cthulhu-rider cthulhu-rider commented Feb 15, 2023

Zero value before:

       RangeHASH    Range      Search     Delete     Put        Head       Get
0 1    0 1 0 1      0 0 0 0    0 1 0 1    0 0 0 0    0 1 0 0    0 1 0 1    0 1 0 1
X F    U S O B      U S O B    U S O B    U S O B    U S O B    U S O B    U S O B
  X-Sticky F-Final U-User S-System O-Others B-Bearer

Now:

       RangeHASH    Range      Search     Delete     Put        Head       Get
0 0    0 1 0 0      0 0 0 0    0 1 0 0    0 0 0 0    0 1 0 0    0 1 0 0    0 1 0 0
X F    U S O B      U S O B    U S O B    U S O B    U S O B    U S O B    U S O B
  X-Sticky F-Final U-User S-System O-Others B-Bearer

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this pull request Feb 15, 2023
In previous implementation pretty-printer of basic ACL in NeoFS CLI had
mistakes:
 * F-bit was set to `Extendable()` property instead of its inversion
 * B-bits were set to `acl.RoleInnerRing` rights

Make `PrettyPrintTableBACL` to correctly render mentioned bits.

Signed-off-by: Leonard Lyubich <ctulhurider@gmail.com>
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #2259 (36710c2) into master (d4b108d) will not change coverage.
The diff coverage is n/a.

❗ Current head 36710c2 differs from pull request most recent head 49aa4fd. Consider uploading reports for the commit 49aa4fd to get more accurate results

@@           Coverage Diff           @@
##           master    #2259   +/-   ##
=======================================
  Coverage   30.71%   30.71%           
=======================================
  Files         383      383           
  Lines       28278    28278           
=======================================
  Hits         8685     8685           
  Misses      18863    18863           
  Partials      730      730           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

In previous implementation pretty-printer of basic ACL in NeoFS CLI had
mistakes:
 * F-bit was set to `Extendable()` property instead of its inversion
 * B-bits were set to `acl.RoleInnerRing` rights

Make `PrettyPrintTableBACL` to correctly render mentioned bits.

Signed-off-by: Leonard Lyubich <ctulhurider@gmail.com>
@cthulhu-rider cthulhu-rider merged commit 3bd0b70 into nspcc-dev:master Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants