IR: Fix incorrect way of IR listing with notary Sidechain #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthulhu-rider
added
bug
Codecov Report
@@ Coverage Diff @@
## master #2283 +/- ##
==========================================
- Coverage 30.67% 30.66% -0.01%
==========================================
Files 383 383
Lines 28314 28316 +2
==========================================
- Hits 8685 8684 -1
- Misses 18899 18902 +3
Partials 730 730
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
After 3400a07 Inner Ring app switched to calling `innerRingList` method of the Netmap contract to list Inner Ring members in notary setting. Described approach is incorrect: in notary installation Inner Ring composition should be fetched using Neo native RoleManagement contract. Misbehavior was caused by basing the condition on the notary setup of the Mainchain instead of Sidechain. Use `IrFetcherWithNotary` as `IRFetcher` when Notary service is enabled in the Sidechain regardless of the Mainchain setting. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
bugfix/ir-lister
branch
from
13c5805
to
0ffaf32
Compare
roman-khimov
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caught while testing nspcc-dev/neofs-contract#324 with removed
innerRingListmethod.Implementation did not comply with the requirements https://pkg.go.dev/github.com/nspcc-dev/neofs-contract@v0.16.0/netmap#InnerRingList