adm: fix wrong nnsResolveKey() code #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
added
bug
Codecov Report
@@ Coverage Diff @@
## master #2296 +/- ##
==========================================
- Coverage 29.82% 29.82% -0.01%
==========================================
Files 400 400
Lines 30398 30401 +3
==========================================
Hits 9066 9066
- Misses 20592 20595 +3
Partials 740 740
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I have no idea how it was tested/used, but NeoFS NNS contracts returns an array from resolve(), therefore this code just can't work correctly (assuming some byte string to returned directly). Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
fix-adm-nns-resolve
branch
from
2422407
to
3b997dc
Compare
cthulhu-rider
approved these changes
Apr 10, 2023
|
Neofs_Adm_Tests is broken, no green runs for the past ~six months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea how it was tested/used, but NeoFS NNS contracts returns an array from resolve(), therefore this code just can't work correctly (assuming some byte string to returned directly).