engine: Do not ignore+detach shards with failed Open/Init ops #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2464 +/- ##
==========================================
- Coverage 29.47% 29.38% -0.10%
==========================================
Files 399 399
Lines 30433 30385 -48
==========================================
- Hits 8971 8928 -43
+ Misses 20718 20714 -4
+ Partials 744 743 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cthulhu-rider
force-pushed
the
bugfix/blobstor-init-failure
branch
from
650a09f
to
896f36f
Compare
roman-khimov
reviewed
Aug 4, 2023
roman-khimov
approved these changes
Aug 4, 2023
Previously, storage engine ignored configured shards if they failed to open/init (with at least one successful). This behavior is unclear: if engine is configured to work with N shards, then all N shards must work, otherwise, the whole engine is broken and needs to be reconfigured. Immediately fail engine's `Open`/`Init` methods on any shard failure. With this, it's redundant to open/init shard concurrently, so they are processed one-by-one now. In the future, possibly, optional config flag will be added to ignore problem shards, but default behavior will be kept strict. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
bugfix/blobstor-init-failure
branch
from
896f36f
to
fddda3e
Compare
carpawell
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, storage engine ignored configured shards if they failed to open/init (with at least one successful). This behavior is unclear: if engine is configured to work with N shards, then all N shards must work, otherwise, the whole engine is broken and needs to be reconfigured.
Immediately fail engine's
Open/Initmethods on any shard failure. With this, it's redundant to open/init shard concurrently, so they are processed one-by-one now.In the future, possibly, optional config flag will be added to ignore problem shards, but default behavior will be kept strict.