Fix/Do not store estimations forever #2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carpawell
force-pushed
the
fix/do-not-store-estimations-forever
branch
from
bc7c6e1
to
7a5f8ef
Compare
Codecov Report
@@ Coverage Diff @@
## master #2472 +/- ##
==========================================
+ Coverage 29.24% 29.25% +0.01%
==========================================
Files 399 399
Lines 30368 30387 +19
==========================================
+ Hits 8881 8891 +10
- Misses 20751 20760 +9
Partials 736 736
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roman-khimov
reviewed
Aug 9, 2023
carpawell
force-pushed
the
fix/do-not-store-estimations-forever
branch
from
7a5f8ef
to
9df591a
Compare
cthulhu-rider
approved these changes
Aug 9, 2023
|
Yeah, can't be compiled at the moment. |
carpawell
force-pushed
the
fix/do-not-store-estimations-forever
branch
from
9df591a
to
bae2e74
Compare
|
Underpush. Fixed. |
carpawell
force-pushed
the
fix/do-not-store-estimations-forever
branch
from
bae2e74
to
20a00ef
Compare
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
For debug purposes. May be dropped in the future. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
For debug purposes. May be dropped in the future. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Not needed for a util with such a limited usage. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
force-pushed
the
fix/do-not-store-estimations-forever
branch
from
20a00ef
to
95eae6d
Compare
|
|
roman-khimov
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, improves estimations debug logs.