ir: Always enable RPC sessions in local consensus launch mode #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2532 +/- ##
==========================================
- Coverage 29.69% 29.68% -0.02%
==========================================
Files 404 404
Lines 30711 30711
==========================================
- Hits 9121 9117 -4
- Misses 20822 20825 +3
- Partials 768 769 +1 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roman-khimov
approved these changes
Aug 29, 2023
RPC sessions must always be supported for the NeoFS Sidechain. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
bugfix/ir-consensus-sessions
branch
from
89837e1
to
142f607
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@roman-khimov @AnnaShaleva note that i've left other session-related configurations unset https://pkg.go.dev/github.com/nspcc-dev/neo-go@v0.101.4/pkg/config#RPC, if u have any suggestions about non-default values pls let me know
(*neo.ContractReader).GetAllCandidatesdoesn't work as expected neo-go#3106