Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neofs-lens: add new command object get #2543

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

AliceInHunterland
Copy link
Contributor

Added neofs-lens object get --address cid/oid --config ./config-sn.yaml --out test.json This command pulls out the object from the StorageEngine physical snapshot.

Closes #1336.

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #2543 (afc96e3) into master (4aab937) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head afc96e3 differs from pull request most recent head 2185c77. Consider uploading reports for the commit 2185c77 to get more accurate results

@@            Coverage Diff             @@
##           master    #2543      +/-   ##
==========================================
- Coverage   29.82%   29.81%   -0.01%     
==========================================
  Files         405      405              
  Lines       30885    30880       -5     
==========================================
- Hits         9210     9206       -4     
+ Misses      20884    20881       -3     
- Partials      791      793       +2     
Files Changed Coverage Δ
cmd/neofs-node/config.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AliceInHunterland AliceInHunterland force-pushed the feature/1336-neofs-lens-pull-object branch from 5b3a52b to d24255a Compare September 4, 2023 11:58
CHANGELOG.md Outdated Show resolved Hide resolved
cmd/neofs-lens/internal/object/root.go Outdated Show resolved Hide resolved
cmd/neofs-lens/internal/object/root.go Outdated Show resolved Hide resolved
cmd/neofs-lens/internal/object/root.go Outdated Show resolved Hide resolved
cmd/neofs-lens/internal/object/root.go Outdated Show resolved Hide resolved
cmd/neofs-lens/internal/object/get.go Outdated Show resolved Hide resolved
cmd/neofs-lens/internal/object/get.go Outdated Show resolved Hide resolved
cmd/neofs-lens/internal/object/get.go Outdated Show resolved Hide resolved
cmd/neofs-lens/internal/object/get.go Outdated Show resolved Hide resolved
cmd/neofs-lens/internal/object/get.go Outdated Show resolved Hide resolved
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit, but somewhat frightening to merge for 0.38.0

CHANGELOG.md Show resolved Hide resolved
cmd/neofs-lens/internal/flags.go Outdated Show resolved Hide resolved
cmd/neofs-lens/internal/storage/inspect.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
AliceInHunterland added a commit that referenced this pull request Sep 11, 2023
With payload-only flag the inspect commands save only payload of the
object, otherwise full object will be saved.

Refs #2543.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
This command pulls out the object from the StorageEngine physical
snapshot using storage node config.

Closes #1336.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
With payload-only flag the inspect commands save only payload of the
object, otherwise full object will be saved.

Refs #2543.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@roman-khimov roman-khimov merged commit b299310 into master Sep 12, 2023
8 of 9 checks passed
@roman-khimov roman-khimov deleted the feature/1336-neofs-lens-pull-object branch September 12, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull an object from node's local storage snapshot
4 participants