Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boltdb: increase timeout to 1s #2604

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

AliceInHunterland
Copy link
Contributor

Previously, we always use 100ms timeout for BoltDB flocks.

Closes: #2499.

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #2604 (9e2ccbb) into master (413a6d2) will not change coverage.
The diff coverage is 71.42%.

❗ Current head 9e2ccbb differs from pull request most recent head e91ceb3. Consider uploading reports for the commit e91ceb3 to get more accurate results

@@           Coverage Diff           @@
##           master    #2604   +/-   ##
=======================================
  Coverage   29.72%   29.72%           
=======================================
  Files         407      407           
  Lines       31145    31145           
=======================================
  Hits         9257     9257           
  Misses      21077    21077           
  Partials      811      811           
Files Coverage Δ
...kg/local_object_storage/blobovnicza/blobovnicza.go 82.85% <100.00%> (ø)
pkg/local_object_storage/blobstor/peapod/peapod.go 73.36% <100.00%> (ø)
pkg/local_object_storage/pilorama/boltdb.go 80.40% <100.00%> (ø)
pkg/local_object_storage/writecache/util.go 100.00% <100.00%> (ø)
pkg/services/session/storage/persistent/options.go 53.84% <100.00%> (ø)
cmd/neofs-node/config.go 0.00% <0.00%> (ø)
cmd/neofs-node/session.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@cthulhu-rider cthulhu-rider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might as well be just time.Second for brevity

@AliceInHunterland AliceInHunterland force-pushed the feature/2499-boltdb-timeout-increase branch from 495ad73 to a4da6ac Compare October 2, 2023 09:55
CHANGELOG.md Outdated Show resolved Hide resolved
Previously, we always use 100ms timeout for BoltDB flocks. This value
may be not enough, it's proposed to increase open timeout to 1s.

Closes: #2499.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@AliceInHunterland AliceInHunterland force-pushed the feature/2499-boltdb-timeout-increase branch from a4da6ac to e91ceb3 Compare October 2, 2023 10:58
@roman-khimov roman-khimov merged commit 1be93e6 into master Oct 2, 2023
9 checks passed
@roman-khimov roman-khimov deleted the feature/2499-boltdb-timeout-increase branch October 2, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise (increase) BoltDB open timeout
4 participants