Several NeoFS chain autodeploy/update fixes #2683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2683 +/- ##
==========================================
- Coverage 30.08% 28.49% -1.60%
==========================================
Files 406 413 +7
Lines 30182 31961 +1779
==========================================
+ Hits 9081 9108 +27
- Misses 20320 22073 +1753
+ Partials 781 780 -1 ☔ View full report in Codecov by Sentry. |
cthulhu-rider
force-pushed
the
bugfix/fschain-autoupdate
branch
3 times, most recently
from
167612c
to
0a8be85
Compare
cthulhu-rider
requested review from
roman-khimov and
carpawell
as code owners
cthulhu-rider
force-pushed
the
bugfix/fschain-autoupdate
branch
from
0a8be85
to
7063351
Compare
roman-khimov
approved these changes
Dec 18, 2023
pkg/morph/deploy/funds.go
Outdated
| } | ||
| } | ||
|
|
||
| func divideFundsEvenlyU64(fullAmount uint64, n int, f func(ind int, amount uint64)) { |
There was a problem hiding this comment.
One version is enough. We can't have more than 100M NEO.
cthulhu-rider
force-pushed
the
bugfix/fschain-autoupdate
branch
from
7063351
to
078e5ea
Compare
Previously, auto-deploy/update procedure could stuck when committee multi-sig account had less than N amount of NEO, where N is a number of the NeoFS Alphabet accounts in the deployed/update NeoFS network. This was caused by rounding integer division of fund amounts: zero funds were transferred due to which the balance did not change and each iteration did not change the network state. Fix zero transfers and also distribute remainder as evenly as possible to decrease total number of transactions. Fixes #2681. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Previously, NeoFS chain auto-update procedure calculated nonce and ValidUntilBlock of the update transactions from the latest NeoFS epoch. This could lead to a deadlock if the epochs were not ticking (and this could have various reasons). To prevent such problems and at the same time simplify the formation of transactions, it makes sense to base height parameters on the current blockchain height only. Set nonce/ValidUntilBlock to lower/upper multiple of 100 relative to current height. Fixes #2680. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
bugfix/fschain-autoupdate
branch
from
078e5ea
to
6128055
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.