Migrate part of s3 tests to dynamic env #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleg Kulachenko <oleg@nspcc.ru>
vvarg229
requested review from
roman-khimov,
cthulhu-rider and
evgeniiz321
as code owners
There was a problem hiding this comment.
@vvarg229 i've reviewed bucket and gate files only by now. Overall everything looks great to me
it's a bit strange to me to see test_s3_gate.py file in s3_gate besides seeing S3 API tests in it. Is this file intended for NeoFS S3 Gateway specifics not covered by the protocol?
i've left some questions and suggestions from my own, if u'll find any of them useful, feel free to postpone them via issues, i understand that this PR is about migration, not enhancements
i don't plan to look closely at the other tests (at least for now), hope @evgeniiz321 @roman-khimov will help
evgeniiz321
approved these changes
Dec 30, 2023
MaxGelbakhiani
approved these changes
Dec 31, 2023
This was referenced Jan 9, 2024
vvarg229
added a commit
to vvarg229/neofs-testcases
that referenced
this pull request
Jan 9, 2024
In the discussion nspcc-dev#699 (comment) it was noted that we don't have to use `PutBucketTagging` before `PutObjectTagging`. This commit removes PutBucketTagging in the test_s3_api_object_tagging test. Signed-off-by: Oleg Kulachenko <oleg@nspcc.ru>
This was referenced Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.