nsqd: protect channel close on topic exit

nsqio · Mar 21, 2021 · ec2c44f · ec2c44f
1 parent adc3e0d
commit ec2c44f
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/nsqd/topic.go b/nsqd/topic.go
@@ -384,13 +384,15 @@ func (t *Topic) exit(deleted bool) error {
 	}
 
 	// close all the channels
+	t.RLock()
 	for _, channel := range t.channelMap {
 		err := channel.Close()
 		if err != nil {
 			// we need to continue regardless of error to close all the channels
 			t.nsqd.logf(LOG_ERROR, "channel(%s) close - %s", channel.name, err)
 		}
 	}
+	t.RUnlock()
 
 	// write anything leftover to disk
 	t.flush()