Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsqadmin: use go:embed; match graphite key valid charset #1347

Merged

Conversation

jehiah
Copy link
Member

@jehiah jehiah commented May 21, 2021

This updates nsqadmin to query graphite using the correct key names for ephemeral topics and channels (see #1346)

@ploxiln
Copy link
Member

ploxiln commented May 21, 2021

interesting related PR for original statsd: statsd/statsd#155

@mreiferson mreiferson changed the title nsqadmin: match graphite key valid charaset nsqadmin: match graphite key valid charset Aug 15, 2021
@mreiferson mreiferson force-pushed the nsqadmin_query_graphite_ephemeral_topics_1347 branch from 77f3e75 to 7799f53 Compare August 15, 2021 21:21
@mreiferson
Copy link
Member

OK, this also addresses #1317

@mreiferson mreiferson changed the title nsqadmin: match graphite key valid charset nsqadmin: use go:embed; match graphite key valid charset Aug 15, 2021
@mreiferson
Copy link
Member

heh, now the build pipeline requires the previously temporary static/build output files - perhaps we just check them in, so we can see exactly what the inputs are for a given commit?

@mreiferson
Copy link
Member

also, lost "debug mode" from go-bindata, probably something we'll need to reimplement

@ploxiln
Copy link
Member

ploxiln commented Aug 15, 2021

now the build pipeline requires the previously temporary static/build output files - perhaps we just check them in

Yeah, I think we should. It shouldn't be too much, in fact it should be equivalent to bindata.go but a bit nicer. (Otherwise one has to install the npm dep tree and do the js build, just to build and test some changes to the go code, if using go-1.16+)

@mreiferson
Copy link
Member

OK, think that should do it, PTAL!

@mreiferson mreiferson force-pushed the nsqadmin_query_graphite_ephemeral_topics_1347 branch from 6179931 to b20f230 Compare August 16, 2021 00:19
@mreiferson mreiferson merged commit 120356d into nsqio:master Aug 16, 2021
@mreiferson mreiferson deleted the nsqadmin_query_graphite_ephemeral_topics_1347 branch August 16, 2021 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants