Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChangeLog: fix docker hub URL #1243

Merged
merged 1 commit into from
Mar 26, 2020
Merged

ChangeLog: fix docker hub URL #1243

merged 1 commit into from
Mar 26, 2020

Conversation

victorabarros
Copy link
Contributor

@victorabarros victorabarros commented Mar 26, 2020

Hello people!

I'm studing about NSQ and noticed at Docker Page the link to docker image doesn't work. I came to repo and noticed the same at Changelog.
That is redirecting to https://registry.hub.docker.com/u/nsqio/nsq/ and the correct is https://registry.hub.docker.com/r/nsqio/nsq/ with com/r/nsqio/ on route.
image

This my little contribution, thanks for amazing product.

@ploxiln
Copy link
Member

ploxiln commented Mar 26, 2020

Thanks for pointing this out.

The page content for https://nsq.io/deployment/docker.html can be found/fixed in https://github.com/nsqio/nsqio.github.io

For this PR, can you just fix the typo in your git commit title? (hud -> hub)

@ploxiln ploxiln changed the title Fix docker hud url. fix docker hub url in changelog Mar 26, 2020
@victorabarros
Copy link
Contributor Author

Thanks for pointing this out.

The page content for https://nsq.io/deployment/docker.html can be found/fixed in https://github.com/nsqio/nsqio.github.io

For this PR, can you just fix the typo in your git commit title? (hud -> hub)

Commit name fixed. =)

@ploxiln
Copy link
Member

ploxiln commented Mar 26, 2020

... unfortunately this PR now contains both the wrong version and the right version, merged together. if you amend a commit (or rebase a branch) you have to force-push it, even though git's default help message says "cannot fast-forward, you should merge"

no biggie, I'll fix it

@ploxiln ploxiln merged commit 8db8c50 into nsqio:master Mar 26, 2020
@mreiferson mreiferson changed the title fix docker hub url in changelog ChangeLog: fix docker hub URL Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants