topic does not buffer messages after deleting last channel #52
+56
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* when all the channels have been deleted cleanly exit the topic message pump * version bump
jehiah
added a commit
that referenced
this pull request
Oct 8, 2012
topic does not buffer messages after deleting last channel
arussellsaw
pushed a commit
to arussellsaw/nsq
that referenced
this pull request
Mar 5, 2018
config: export & list defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
during testing it was found that when deleting the last channel in a topic that messages were not then buffered at the topic level, this is probably due to not cleaning up the topic message pump.