rdy_timeout handling round 2 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pushed a few commits up and updated issue description |
|
I've pushed up a few more various fixes here. This code is now stable for me and tested on some production systems. I am still thinking through if there is anything else i want to tackle, and i have a few ideas on how to test.
|
* skip redistributing RDY while blocked by backoff * stop callbacks on closed connections * re-schedule backoff on remaining connections * properly send RDY on connect (after IDENTIFY) * log message body on exception * throttle connection attempts * rename various internal methods for clarity * separate a conn's rdy_timeout (for disabled handling) from the reader's global backoff_timeout (and clear backoff_timeout) * force redistribute after a connection closes when in backoff or when it would have toggled out of normal redistribution cases * test improvements * dont 'optimize' when RDY is already the value we want (far far easier to reason in tests) * when completely exiting backoff return to normal operation * choose a random connection when backoff block expires
|
LGTM. squash/rebase please. This set of changes fantastically improves lots of strange edge cases. 🚀 💯 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more cleanup re: #36
rdy_timeoutwas not being cleaned upReaderglobal backoff timers from per-connection RDY delay timers in order to handle connections closing that had the backoff timer statecc @jehiah