Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gutenberg block to use api version 2 #24

Merged
merged 2 commits into from
May 8, 2023

Conversation

NatalieMac
Copy link
Contributor

@NatalieMac NatalieMac commented Apr 28, 2023

We can't reproduce it reliably, but we had a couple of reports from customers that our Draw Attention block wasn't working in WordPress 6.2. It weirdly seems to work on some sites and not others. I ruled out theme and plugin conflicts, but there's something else happening that's causing the block to have problems on some installs and not others.

https://app.asana.com/0/1202131669252825/1204463372846373

@NatalieMac NatalieMac marked this pull request as draft April 28, 2023 22:30
@NatalieMac NatalieMac marked this pull request as ready for review April 28, 2023 22:30
@NatalieMac
Copy link
Contributor Author

Loom video demo and code discussion: https://www.loom.com/share/1ad900c0e9024527be0022c0ed7279eb

Copy link
Collaborator

@tylerdigital tylerdigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NatalieMac should use VSCode instead of Sublime Text, but otherwise approved

Copy link
Contributor

@cynhu92 cynhu92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to confirm it works in both sandboxes and local now 👍

@tylerdigital tylerdigital merged commit b7a5d02 into master May 8, 2023
11 checks passed
@tylerdigital tylerdigital changed the title Update Draw Attention block to use api version 2 Update gutenberg block to use api version 2 May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants