Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nonce checks for additional security #44

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Add nonce checks for additional security #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d49a7b4
initial security fixes
hsein-bitar Oct 25, 2023
14887cb
more permission checks
hsein-bitar Oct 25, 2023
e3484ef
Requiring review from 'cynhu92' ci bypass
otto-bot-git Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added .github/code-review/require-person/cynhu92/PR-44
View file
Open in desktop
Empty file.
6 changes: 6 additions & 0 deletions public/includes/custom_fields.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,12 @@ function hotspot_area_override_title_and_content( $value, $object_id, $args, $fi
function update_hotspot_area_details() {
if ( !isset( $_POST['_pid'] ) ) return;
check_ajax_referer( 'update-hotspot_'.$_POST['_pid'], 'ajaxnonce' );

if( ! current_user_can( 'delete_others_posts' ) ){
status_header(403);
nocache_headers();
wp_die('Bad Request: You do not have permission to access this page');
}

if ( isset( $_POST['_title'] ) ) {
$_POST['_title'] = wp_filter_nohtml_kses( $_POST['_title'] ); // also expects & returns slashes
Expand Down
24 changes: 21 additions & 3 deletions public/includes/import-export.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@ public function process_import() {
if ( empty( $_POST['import_code'] ) ) {
return;
}

// verify nonce
if ( !wp_verify_nonce( $_POST['_wpnonce'], 'da_import_nonce' ) || ! current_user_can( 'delete_others_posts' ) ) {
status_header(403);
nocache_headers();
wp_die('Bad Request: You do not have permission to access this page');
}

$import_code = stripslashes($_POST['import_code']);
$import_array = json_decode( $import_code, true );
if ( empty( $import_array['0']['post']['ID'] ) ) {
Expand Down Expand Up @@ -81,6 +89,13 @@ public function get_export_array( $ids=array() ) {
}

public function get_export_json( $ids=array() ) {
// verify nonce
if ( !wp_verify_nonce( $_POST['_wpnonce'], 'da_export_nonce' ) || ! current_user_can( 'delete_others_posts' ) ) {
status_header(403);
nocache_headers();
wp_die('Bad Request: You do not have permission to access this page');
}

$export_array = $this->get_export_array( $ids );
return json_encode( $export_array );
}
Expand All @@ -92,15 +107,17 @@ public function admin_menu() {
}

public function output_import_export_page() {
// only allow users with capability: "delete_others_posts"
if ( ! current_user_can( 'delete_others_posts' ) ) {
return;
if( ! current_user_can( 'delete_others_posts' ) ){
status_header(403);
nocache_headers();
wp_die('Bad Request: You do not have permission to access this page');
}
?>
<div class="import">
<h3>Import</h3>
<p>If you've already exported from another site, paste the export code below:</p>
<form method="POST" name="import" action="edit.php?post_type=da_image&page=import_export">
<?php wp_nonce_field( 'da_import_nonce' ); ?>
<input type="hidden" name="action" value="import" />
<textarea name="import_code" cols="100" rows="5" placeholder=""></textarea><br />
<input type="submit" value="Import" />
Expand All @@ -124,6 +141,7 @@ public function output_import_export_page() {
<p>Choose images to export</p>
<form method="POST" name="export" action="edit.php?post_type=da_image&page=import_export">
<input type="hidden" name="action" value="export" />
<?php wp_nonce_field( 'da_export_nonce' ); ?>
<?php
$da_images = new WP_Query( array(
'post_type' => 'da_image',
Expand Down
2 changes: 2 additions & 0 deletions public/includes/lib/CMB2/includes/CMB2_Hookup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -910,6 +910,8 @@ public function can_save( $type = '' ) {
// check nonce.
&& isset( $_POST[ $this->cmb->nonce() ] )
&& wp_verify_nonce( $_POST[ $this->cmb->nonce() ], $this->cmb->nonce() )
// check permissions.
&& current_user_can( 'delete_others_posts' )
// check if autosave.
&& ! ( defined( 'DOING_AUTOSAVE' ) && DOING_AUTOSAVE )
// get the metabox types & compare it to this type.
Expand Down