-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CI workflow with a job to format the code on the PR #50
Conversation
… into auto-format
@tylerdigital @NatalieMac hello, this should be ready.
TestingI tested a Draw Attention element that I had previously setup:
I also tested replacing the plugin with a new build, and confirmed it works ✅ |
public/assets/js/leaflet.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we're attempting to un-minify this file. Is there a way to just exclude this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sure, thanks for catching this. I had excluded all files matching min.*
but missed this one. Just excluded the file from formatting now
I looped in Cyndy to do some QA just in case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was testing this, but it seems to be only DA Free, right? Do we have a Pro version to test with?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was doing my testing here: https://pr50-drawattention-cyn.sandbox.ssa.rocks/test/
Tested:
- Creating image ✅
- Deleting image ✅
- Replacing image ✅
- Creating hotspots ✅
- Deleting hotspots ✅
- Editing hotspots ✅
- Using polygon, rectangle, circle hotspots ✅
- Adding shortcodes and links to hotspots ✅
- Adding videos ✅
- Using Go to Url and More info ✅
- Changing hotspot styles and borders ✅
Draw Attention free and Pro are two totally separate repositories (unlike SSA where all versions are in one repo), so they have to be updated and tested separately. @cynhu92 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on sandbox:
Adding main image ✅
Creating hotspot polygon ✅
Creating hotspot square ✅
Creating hotspot circle ✅
Editing hotspots ✅
Zooming and panning ✅
Deleting hotspots ✅
Show description action ✅
Go to URL action ✅
Attach Detail Image ✅
Highlight Styling ✅
More Info Box Styling ✅
Apply Color Scheme ✅
Tested on fresh local:
Adding main image ✅
Creating hotspot polygon ✅
Creating hotspot square ✅
Creating hotspot circle ✅
Editing hotspots ✅
Zooming and panning ✅
Deleting hotspots ✅
Show description action ✅
Go to URL action ✅
Attach Detail Image ✅
Highlight Styling ✅
More Info Box Styling ✅
Apply Color Scheme ✅
Asana
https://app.asana.com/0/1202852195727075/1205992270273982/f
Context
Added CI workflow with a job to format the code on the PR