Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the Thank You section written by Kimmy and updated the cohort JSON #21

Merged
merged 1 commit into from
Feb 28, 2018

Conversation

krnorris65
Copy link
Collaborator

Link to Ticket

#20

Description of Proposed Changes

  • Updated Thank You section (written by Kimmy Bird)

Steps to Test

Outline the steps to test

git fetch --all
git checkout kn-KimmyThankYou

read over Thank You section and make sure there are no errors

also, added more info to the cohort.json for students who updated their information. There isn't anything to test for this

Impacted Areas in Application

List general components of the application that this PR will affect:

  • Thank You section

Mentions @username

Tag users that need to review this code
@Chewieez @john-dulaney

Copy link
Collaborator

@john-dulaney john-dulaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🍔 🇾🇪

@rmbw74
Copy link
Collaborator

rmbw74 commented Feb 28, 2018

Should it be future successes? or Our future success?

@krnorris65 krnorris65 merged commit a79fe5f into master Feb 28, 2018
@krnorris65 krnorris65 deleted the kn-KimmyThankYou branch February 28, 2018 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants