Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please read comments for more detailed notes. Created welcomeLogin page with authentication. #28

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

Massacre-Saint
Copy link
Contributor

  • In main.js, I created the welcomeLogin page that displays the loginButton inside the new "login-form-container" div for styling purposes.
  • I created a navbar function just for the purpose of rendering the logoutButton, since it will need to be there anyways in the future.
  • Added navEvents since the logoutButton is rendered inside the nav, and it can already have functionality.
  • Updated clearDom and domBuilder to match the missing divs.
  • Updated pathing within the file structure for future files.

@netlify
Copy link

netlify bot commented Jun 15, 2022

Deploy Preview for fluffy-kitten-9d4cc8 ready!

Name Link
🔨 Latest commit a674466
🔍 Latest deploy log https://app.netlify.com/sites/fluffy-kitten-9d4cc8/deploys/62aa0e09a75207000a184376
😎 Deploy Preview https://deploy-preview-28--fluffy-kitten-9d4cc8.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Massacre-Saint Massacre-Saint changed the title Please read comment's for more detailed notes. Created welcomeLogin page with authentication. Please read comments for more detailed notes. Created welcomeLogin page with authentication. Jun 15, 2022
Copy link
Contributor

@nishayaraj nishayaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@gitNitroTitan gitNitroTitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetched and checked--no errors. looks like a great start!

@gitNitroTitan gitNitroTitan merged commit 66dc776 into main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants