-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CocoaPods compatibility #3
Comments
Hello, Thank you for writing. I personnaly don't use CocoaPods and don't know its inner working, so I don't feel comfortable in maintaining a 'podspec'. However, I'll be happy if someone do, so feel free to submit it on CocoaPods. STTwitter supports iOS 5+ and Mac OS X 10.7+. The contributors are nst (myself), Frank Dowsett and xnyhps. STTwitter stays on top of STHTTPRequest https://github.com/nst/STHTTPRequest. Contributors: nst (myself), alistairg, sburlot and MSchmidt. Nicolas Seriot |
Nicolas, Ok, I can submit it and also make a fork to update the STTwitter README with simple instructions on how to add STTwitter to a CocoaPods project. The only issue is that it will point to a specific commit (right now be05589). You could also use version numbers, but you're not currently using them. That would be easier because then you could just bump the version number in the podspec when you've made a release. How are you incorporating the changes you make on STHTTPRequest to STTwiiter? I see you have a separate repo for STHTTPRequest, but you also have that same class in Vendor/STHTTPRequest in your STTwitter repo, and it looks like you've made manual changes to it directly in STTwitter. Thanks, |
I can tag version 'be05589' as version '0.0.1'. You can fork STTwitter, add the relevant details in the README and make a pull request then. And yes, until now I've been copying STHTTPRequest into STTwitter from time to time and only after testing that everything was working well. Should I adopt a more formal process to ease integration to CocoaPods? |
Nicolas, Ok, that sounds good—'beo5589' is what I was using to point to. Sure, I'll fork the repo and then make a pull request when I update the README. As far as STHTTPRequest is concerned, it's really up to you. I could include it as a dependency of STTwitter for CocoaPods, and you could then remove it from this repo (and for Git you could also then make it a dependent Git submodule)? Then, in the future, all you'd have to do is change the version tag of STHTTPRequest on its podspec—you wouldn't have to manually make the changes in this repo you'd already made there. But if you're comfortable doing it this way, that works, too. Just let me know. Evan |
I think it's best that STTwitter does not require CocoaPods for the STHTTPRequest dependancy. Maybe in the future I'll use a Git submodule, but for now I prefer being overly cautious to avoid accidentally breaking something and I'll keep on duplicating tested versions of STHTTPRequest into the STTwitter repository. |
Ok, sure- I understand. It all boils down to what works best for you! Ok, I'll just wait for you to tag "beo5589' as release '0.0.1,' then make the change and submit it to the CocoaPods master repo. I'll start working on the README in the meantime. Thanks, |
Ok I merged your changes in the README and tagged the latest version afterwards. |
Forked and pulled into the CocoaPods master repo, visible at https://github.com/CocoaPods/Specs. I tested it in my project and it's working. I can teach you how to edit the podspec to make future releases available, or you can let me know and I can do it. Evan |
Thank you! |
Hi,
I was going to use STTwitter in a project that I've already set up with CocoaPods (http://cocoapods.org/) and noticed that you don't have a pod set up, so I went ahead and created a podspec for it. I have it hosted as a private gist currently, but if you have interest in making STTwitter available as a pod for everyone to use I can submit it to CocoaPods and they would host the podspec file. That way, it'd be as easy as including 'pod STTwitter' in a project using CocoaPods to utilize it.
Here's the gist, it's only really missing any additional author(s) besides yourself (as well as email addresses, if you want them included), and supported OS X versions:
https://gist.github.com/eroth/573f80056acf53f4dbca/raw/9ef10dc0ff4dd54ba81e3c3110ca6a44a57971f6/STTwitter.podspec
Cheers!
The text was updated successfully, but these errors were encountered: