Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GET lists/statuses implementation #6

Closed
eroth opened this issue Jun 6, 2013 · 3 comments
Closed

Adding GET lists/statuses implementation #6

eroth opened this issue Jun 6, 2013 · 3 comments
Assignees

Comments

@eroth
Copy link

eroth commented Jun 6, 2013

Hi, I wanted to add GET lists/statuses implementation to STTwitterAPIWrapper and have created methods to do so using either the list ID or the list slug and owner screen name. My question is regarding the method - (void)getTimeline. I'm wondering if it should still stay named "getTimeline" if it can be used to retrieve other resources, such as a list? In my code, I just called this method instead of duplicating it and creating another method called "getList."

So, first, is it ok to use the existing getTimeline method for this (it works fine with my code) and, if so, should it be possibly renamed to something not so confining, such as "getResource," since it's not retrieving a timeline in this case? I do see that STTwitterAppOnly has a "getResource" method, so I don't know if you think that might be too confusing.

When you get a chance to answer this, I can then submit a pull request.

Thanks,
Evan

@ghost ghost assigned nst Jun 7, 2013
@nst
Copy link
Owner

nst commented Jun 7, 2013

STTwitterAPIWrapper is really a mapping from Twitter API endpoints to Cocoa objects.

I think that STTwitterAPIWrapper methods should clearly say what the user will receive.

I really prefer having multiple methods with names such as getMentionsTimelineSinceID:, getUserTimelineWithScreenName: and so on with clear parameter names instead of generic names such as getResource. Of course, it does not mean that the code has to be duplicated, as you can see in STTwitterAPIWrapper.m.

@nst nst closed this as completed Jun 11, 2013
@eroth
Copy link
Author

eroth commented Jun 26, 2013

Working on adding these GET lists/statuses methods now, should be submitting a pull request in the next few days.

@eroth
Copy link
Author

eroth commented Jun 26, 2013

Never mind, just saw you added them already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants