You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I wanted to add GET lists/statuses implementation to STTwitterAPIWrapper and have created methods to do so using either the list ID or the list slug and owner screen name. My question is regarding the method - (void)getTimeline. I'm wondering if it should still stay named "getTimeline" if it can be used to retrieve other resources, such as a list? In my code, I just called this method instead of duplicating it and creating another method called "getList."
So, first, is it ok to use the existing getTimeline method for this (it works fine with my code) and, if so, should it be possibly renamed to something not so confining, such as "getResource," since it's not retrieving a timeline in this case? I do see that STTwitterAppOnly has a "getResource" method, so I don't know if you think that might be too confusing.
When you get a chance to answer this, I can then submit a pull request.
Thanks,
Evan
The text was updated successfully, but these errors were encountered:
STTwitterAPIWrapper is really a mapping from Twitter API endpoints to Cocoa objects.
I think that STTwitterAPIWrapper methods should clearly say what the user will receive.
I really prefer having multiple methods with names such as getMentionsTimelineSinceID:, getUserTimelineWithScreenName: and so on with clear parameter names instead of generic names such as getResource. Of course, it does not mean that the code has to be duplicated, as you can see in STTwitterAPIWrapper.m.
Hi, I wanted to add GET lists/statuses implementation to STTwitterAPIWrapper and have created methods to do so using either the list ID or the list slug and owner screen name. My question is regarding the method - (void)getTimeline. I'm wondering if it should still stay named "getTimeline" if it can be used to retrieve other resources, such as a list? In my code, I just called this method instead of duplicating it and creating another method called "getList."
So, first, is it ok to use the existing getTimeline method for this (it works fine with my code) and, if so, should it be possibly renamed to something not so confining, such as "getResource," since it's not retrieving a timeline in this case? I do see that STTwitterAppOnly has a "getResource" method, so I don't know if you think that might be too confusing.
When you get a chance to answer this, I can then submit a pull request.
Thanks,
Evan
The text was updated successfully, but these errors were encountered: