-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sampling Potentials Architecture #17
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
===========================================
- Coverage 100.00% 91.05% -8.95%
===========================================
Files 2 14 +12
Lines 28 313 +285
===========================================
+ Hits 28 285 +257
- Misses 0 28 +28
Continue to review full report at Codecov.
|
666e6f8
to
2353518
Compare
architecture add notebook CI comments update gitignore example notebook Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
eb8ecaf
to
44026cd
Compare
dd4ba20
to
6d591b4
Compare
@CCAstro35 cd path/to/discO
pre-commit run —all-files will clean up any code and documentation |
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@CCAstro35 , except for AGAMA stuff, the test suite works well. |
The one thing I haven't resolved is whether |
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@nstarman I agree. (nsamp, niter) makes more intuitive sense to me dimensionally, but what you said about making realizations easier is an important point though. I can see either way, but the latter works with me. |
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
I got the measurement sampler working on shaped SkyCoord arrays. It all pipes beautifully�. |
Description
Before we start calculating residuals, we want a code-agnostic method of sampling from a potential.
This introduces a registry system for adding sampling classes.
PR Checklist
CHANGES.rst
file. See existing changelog for examples.docs
folder.