Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from template #18

Merged
merged 29 commits into from
Nov 20, 2020
Merged

Update from template #18

merged 29 commits into from
Nov 20, 2020

Conversation

nstarman
Copy link
Collaborator

@nstarman nstarman commented Nov 20, 2020

Description

General update from @nstarman project template.

PR Checklist

  • Check out the contributing guidelines and code of conduct
  • Check out the contributing workflow ( for a practical example click here )
  • Give a detailed description of the PR above.
  • Document changes in the CHANGES.rst file. See existing changelog for examples.
  • Add tests, if applicable, to ensure code coverage never decreases.
  • Make sure the docs are up to date, if applicable, particularly the docstrings and RST files in docs folder.
  • Ensure linear history by rebasing, when requested by the maintainer.

@nstarman nstarman added the enhancement New feature or request label Nov 20, 2020
@nstarman nstarman added this to the v0.1 milestone Nov 20, 2020
@nstarman nstarman self-assigned this Nov 20, 2020
@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #18 (4bd6302) into master (e72fdf5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           23        28    +5     
=========================================
+ Hits            23        28    +5     
Impacted Files Coverage Δ
discO/__init__.py 100.00% <100.00%> (ø)
discO/data/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72fdf5...4bd6302. Read the comment docs.

Signed-off-by: Nathaniel Starkman <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>

# Conflicts:
#	setup.cfg
Signed-off-by: Nathaniel Starkman <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>

# Conflicts:
#	CHANGES.rst
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@GalOrrery GalOrrery deleted a comment from pep8speaks Nov 20, 2020
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@GalOrrery GalOrrery deleted a comment from pep8speaks Nov 20, 2020
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@GalOrrery GalOrrery deleted a comment from pep8speaks Nov 20, 2020
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@GalOrrery GalOrrery deleted a comment from pep8speaks Nov 20, 2020
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@GalOrrery GalOrrery deleted a comment from pep8speaks Nov 20, 2020
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@GalOrrery GalOrrery deleted a comment from pep8speaks Nov 20, 2020
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@GalOrrery GalOrrery deleted a comment from pep8speaks Nov 20, 2020
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@GalOrrery GalOrrery deleted a comment from pep8speaks Nov 20, 2020
@nstarman
Copy link
Collaborator Author

@CCAstro35, ready for review.

@nstarman nstarman merged commit 9bc1a1e into master Nov 20, 2020
@nstarman nstarman deleted the update-from-template branch November 20, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs enhancement New feature or request GitHub
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants