Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up frame and representation treatment #45

Merged
merged 6 commits into from
Feb 16, 2021
Merged

Conversation

nstarman
Copy link
Collaborator

@nstarman nstarman commented Feb 16, 2021

Description

It was pretty scattered. Now strings, classes, instances, None, and Ellipsis should be handled the same way for both frames and representations.

PR Checklist

  • Check out the contributing guidelines and code of conduct
  • Check out the contributing workflow ( for a practical example click here )
  • Give a detailed description of the PR above.
  • Document changes in the CHANGES.rst file. See existing changelog for examples.
  • Add tests, if applicable, to ensure code coverage never decreases.
  • Make sure the docs are up to date, if applicable, particularly the docstrings and RST files in docs folder.
  • Ensure linear history by rebasing, when requested by the maintainer.

Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@nstarman nstarman added this to the v0.1 milestone Feb 16, 2021
@nstarman nstarman self-assigned this Feb 16, 2021
@github-actions github-actions bot added the utils label Feb 16, 2021
@nstarman nstarman changed the title clean up frame and representation type treatment clean up frame and representation treatment Feb 16, 2021
@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #45 (bc5487d) into master (f808c5a) will increase coverage by 1.37%.
The diff coverage is 89.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   83.87%   85.24%   +1.37%     
==========================================
  Files          25       26       +1     
  Lines        1234     1349     +115     
==========================================
+ Hits         1035     1150     +115     
  Misses        199      199              
Impacted Files Coverage Δ
discO/core/core.py 100.00% <ø> (ø)
discO/plugin/agama/fitter.py 0.00% <0.00%> (ø)
discO/plugin/agama/sample.py 0.00% <0.00%> (ø)
discO/plugin/agama/wrapper.py 0.00% <0.00%> (ø)
discO/core/pipeline.py 64.37% <76.92%> (+16.40%) ⬆️
discO/core/wrapper.py 98.50% <98.50%> (ø)
discO/config.py 100.00% <100.00%> (ø)
discO/core/__init__.py 100.00% <100.00%> (ø)
discO/core/fitter.py 100.00% <100.00%> (ø)
discO/core/measurement.py 99.00% <100.00%> (+0.04%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f808c5a...bc5487d. Read the comment docs.

Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@github-actions github-actions bot added the Docs label Feb 16, 2021
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@nstarman nstarman merged commit 71d4032 into master Feb 16, 2021
@nstarman nstarman deleted the clean_frame_treatment branch February 16, 2021 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant