Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics #50

Merged
merged 4 commits into from
Feb 26, 2021
Merged

statistics #50

merged 4 commits into from
Feb 26, 2021

Conversation

nstarman
Copy link
Collaborator

@nstarman nstarman commented Feb 26, 2021

Description

Start collecting some statistics files

PR Checklist

  • Check out the contributing guidelines and code of conduct
  • Check out the contributing workflow ( for a practical example click here )
  • Give a detailed description of the PR above.
  • Document changes in the CHANGES.rst file. See existing changelog for examples.
  • Add tests, if applicable, to ensure code coverage never decreases.
  • [] Make sure the docs are up to date, if applicable, particularly the docstrings and RST files in docs folder.
  • Ensure linear history by rebasing, when requested by the maintainer.

@nstarman nstarman added this to the v0.1 milestone Feb 26, 2021
@nstarman nstarman self-assigned this Feb 26, 2021
@nstarman nstarman added this to In progress in Paper 1 via automation Feb 26, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the Docs label Feb 26, 2021
@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #50 (28718a4) into master (3bfadba) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   85.37%   85.44%   +0.06%     
==========================================
  Files          27       28       +1     
  Lines        1477     1484       +7     
==========================================
+ Hits         1261     1268       +7     
  Misses        216      216              
Impacted Files Coverage Δ
discO/core/statistic.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bfadba...74d2fd9. Read the comment docs.

**only works on the acceleration observeable**

Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@nstarman nstarman merged commit 40e6542 into master Feb 26, 2021
Paper 1 automation moved this from In progress to Done Feb 26, 2021
@nstarman nstarman deleted the statistic branch February 26, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant