Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run pipe with existing samples #51

Merged
merged 7 commits into from
Mar 1, 2021
Merged

run pipe with existing samples #51

merged 7 commits into from
Mar 1, 2021

Conversation

nstarman
Copy link
Collaborator

Signed-off-by: Nathaniel Starkman (@nstarman) nstarkman@protonmail.com

Description

Run pipeline with existing samples

PR Checklist

  • Check out the contributing guidelines and code of conduct
  • Check out the contributing workflow ( for a practical example click here )
  • Give a detailed description of the PR above.
  • Document changes in the CHANGES.rst file. See existing changelog for examples.
  • Add tests, if applicable, to ensure code coverage never decreases.
  • Make sure the docs are up to date, if applicable, particularly the docstrings and RST files in docs folder.
  • Ensure linear history by rebasing, when requested by the maintainer.

@nstarman nstarman added this to the v0.1 milestone Feb 26, 2021
@nstarman nstarman self-assigned this Feb 26, 2021
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #51 (95e6090) into master (40e6542) will decrease coverage by 0.55%.
The diff coverage is 67.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   85.44%   84.89%   -0.56%     
==========================================
  Files          28       28              
  Lines        1484     1516      +32     
==========================================
+ Hits         1268     1287      +19     
- Misses        216      229      +13     
Impacted Files Coverage Δ
discO/plugin/agama/sample.py 0.00% <ø> (ø)
discO/statistic.py 100.00% <ø> (ø)
discO/core/pipeline.py 65.29% <28.57%> (-4.19%) ⬇️
discO/plugin/galpy/fitter.py 98.46% <91.66%> (-1.54%) ⬇️
discO/core/sample.py 100.00% <100.00%> (ø)
discO/plugin/galpy/sample.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40e6542...95e6090. Read the comment docs.

Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@nstarman nstarman merged commit c4acfee into master Mar 1, 2021
@nstarman nstarman deleted the run_with_samples branch March 1, 2021 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant