Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrackStream and StreamTrack #13

Merged
merged 1 commit into from
Nov 2, 2020
Merged

TrackStream and StreamTrack #13

merged 1 commit into from
Nov 2, 2020

Conversation

nstarman
Copy link
Owner

@nstarman nstarman commented Sep 26, 2020

Signed-off-by: Nathaniel Starkman nstarkman@protonmail.com

Description

The master class for fitting stream tracks.

There are two basic classes: TrackStream for fitting data and StreamTrack for the fit result.

PR Checklist

@nstarman nstarman self-assigned this Sep 26, 2020
@nstarman nstarman force-pushed the StreamTrack branch 2 times, most recently from fe592cc to 42c2006 Compare October 26, 2020 20:57
@nstarman nstarman added this to the v0.1.0 milestone Oct 26, 2020
@nstarman nstarman force-pushed the StreamTrack branch 4 times, most recently from 5771133 to 5abd567 Compare October 30, 2020 06:57
@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #13 into master will increase coverage by 7.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   74.75%   81.97%   +7.22%     
==========================================
  Files          10       12       +2     
  Lines         202      283      +81     
==========================================
+ Hits          151      232      +81     
  Misses         51       51              
Impacted Files Coverage Δ
trackstream/__init__.py 100.00% <100.00%> (ø)
trackstream/common.py 100.00% <100.00%> (ø)
trackstream/core.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9c7c49...7ed0366. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Oct 30, 2020

Hello @nstarman! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 95:80: E501 line too long (81 > 79 characters)

Comment last updated at 2020-11-02 05:20:57 UTC

* Trackstream
* changelog
* type annotation
* Test StreamTrack
* add core to top-level
* add common
* Test TrackStream
* ignore conf.py
* test representation
* stringent error check
* changelog
* docs
* import tests

Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@nstarman nstarman merged commit d096685 into master Nov 2, 2020
@nstarman nstarman deleted the StreamTrack branch November 2, 2020 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants