Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spline with units #24

Merged
merged 6 commits into from
Oct 30, 2020
Merged

spline with units #24

merged 6 commits into from
Oct 30, 2020

Conversation

nstarman
Copy link
Owner

@nstarman nstarman commented Oct 28, 2020

Signed-off-by: nstarman nstarman@users.noreply.github.com

Description

SciPy splines that work with Astropy Quantities.

PR Checklist

  • Check out the contributing guidelines and code of conduct
  • Check out the contributing workflow ( for a practical example click here )
  • Give a detailed description of the PR above.
  • Document changes in the CHANGES.rst file. See existing changelog for examples.
  • Add tests, if applicable, to ensure code coverage never decreases.
  • Make sure the docs are up to date, if applicable, particularly the docstrings and RST files in docs folder.
  • Ensure linear history by rebasing, when requested by the maintainer.

@nstarman nstarman self-assigned this Oct 28, 2020
@nstarman nstarman added the enhancement New feature or request label Oct 28, 2020
@nstarman nstarman added this to the v0.1.0 milestone Oct 28, 2020
nstarman and others added 4 commits October 29, 2020 20:27
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: Nathaniel Starkman <(@nstarman)>
Signed-off-by: Nathaniel Starkman <(@nstarman)>
@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #24 into master will increase coverage by 6.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   68.51%   74.75%   +6.23%     
==========================================
  Files           9       10       +1     
  Lines         162      202      +40     
==========================================
+ Hits          111      151      +40     
  Misses         51       51              
Impacted Files Coverage Δ
trackstream/utils/__init__.py 100.00% <100.00%> (ø)
trackstream/utils/spline.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15b3df2...7e971ab. Read the comment docs.

Signed-off-by: Nathaniel Starkman (@nstarman) <nstarman@users.noreply.github.com>
@pep8speaks
Copy link

pep8speaks commented Oct 30, 2020

Hello @nstarman! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 389:80: E501 line too long (82 > 79 characters)

Comment last updated at 2020-10-30 06:41:38 UTC

@github-actions github-actions bot added the Docs label Oct 30, 2020
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarman@users.noreply.github.com>
@nstarman nstarman merged commit e9c7c49 into master Oct 30, 2020
@nstarman nstarman deleted the spline_with_units branch October 30, 2020 06:53
@zube zube bot removed the [zube]: Done label Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants