Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve interps #31

Merged
merged 7 commits into from
Feb 8, 2021
Merged

improve interps #31

merged 7 commits into from
Feb 8, 2021

Conversation

nstarman
Copy link
Owner

@nstarman nstarman commented Feb 8, 2021

Signed-off-by: Nathaniel Starkman (@nstarman) nstarkman@protonmail.com

Description

Improve interpolated coordinates

PR Checklist

  • Check out the contributing guidelines and code of conduct
  • Check out the contributing workflow ( for a practical example click here )
  • Give a detailed description of the PR above.
  • Document changes in the CHANGES.rst file. See existing changelog for examples.
  • Add tests, if applicable, to ensure code coverage never decreases.
  • Make sure the docs are up to date, if applicable, particularly the docstrings and RST files in docs folder.
  • Ensure linear history by rebasing, when requested by the maintainer.

Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@nstarman nstarman added this to the v0.1.0 milestone Feb 8, 2021
@nstarman nstarman self-assigned this Feb 8, 2021
@astropy-bot astropy-bot bot added the utils label Feb 8, 2021
@github-actions github-actions bot added the Repo label Feb 8, 2021
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@github-actions github-actions bot added the Docs label Feb 8, 2021
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #31 (a1d6317) into master (d733cc1) will increase coverage by 26.73%.
The diff coverage is 97.54%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #31       +/-   ##
===========================================
+ Coverage   54.23%   80.96%   +26.73%     
===========================================
  Files          21       21               
  Lines        1016     1114       +98     
===========================================
+ Hits          551      902      +351     
+ Misses        465      212      -253     
Impacted Files Coverage Δ
trackstream/utils/path.py 37.70% <25.00%> (ø)
trackstream/utils/interpolated_coordinates.py 98.19% <99.27%> (+68.40%) ⬆️
trackstream/utils/generic_coordinates.py 95.23% <100.00%> (+70.64%) ⬆️
trackstream/utils/interpolate.py 94.23% <0.00%> (+0.96%) ⬆️
trackstream/utils/_framelike.py 100.00% <0.00%> (+61.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d733cc1...a1d6317. Read the comment docs.

Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@nstarman nstarman merged commit f65d0c2 into master Feb 8, 2021
@nstarman nstarman deleted the improve_interps branch February 8, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant