Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hints and configuration #32

Merged
merged 22 commits into from
Mar 3, 2021
Merged

Type hints and configuration #32

merged 22 commits into from
Mar 3, 2021

Conversation

nstarman
Copy link
Owner

@nstarman nstarman commented Feb 8, 2021

Description

update the type hints and configuration.

PR Checklist

  • Check out the contributing guidelines and code of conduct
  • Check out the contributing workflow ( for a practical example click here )
  • Give a detailed description of the PR above.
  • Ensure linear history by rebasing, when requested by the maintainer.
  • Document changes in the CHANGES.rst file. See existing changelog for examples.
  • Add tests, if applicable, to ensure code coverage never decreases.
  • Make sure the docs are up to date, if applicable, particularly the docstrings and RST files in docs folder.

@nstarman nstarman added this to the v0.1.0 milestone Feb 8, 2021
@nstarman nstarman self-assigned this Feb 8, 2021
@astropy-bot astropy-bot bot added the utils label Feb 8, 2021
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@github-actions github-actions bot added the Docs label Feb 9, 2021
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #32 (9ba906c) into master (f65d0c2) will decrease coverage by 0.59%.
The diff coverage is 77.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   80.96%   80.37%   -0.60%     
==========================================
  Files          21       20       -1     
  Lines        1114     1121       +7     
==========================================
- Hits          902      901       -1     
- Misses        212      220       +8     
Impacted Files Coverage Δ
trackstream/utils/coordinates.py 65.00% <ø> (-3.19%) ⬇️
trackstream/utils/utils.py 35.71% <35.71%> (ø)
trackstream/example_data/example_orbit.py 40.00% <50.00%> (-1.31%) ⬇️
trackstream/example_data/example_nbody.py 56.52% <75.00%> (ø)
trackstream/preprocess/rotated_frame.py 41.43% <90.90%> (+0.55%) ⬆️
trackstream/__init__.py 100.00% <100.00%> (ø)
trackstream/config.py 100.00% <100.00%> (ø)
trackstream/core.py 100.00% <100.00%> (ø)
trackstream/preprocess/utils.py 100.00% <100.00%> (ø)
trackstream/type_hints.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f65d0c2...9ba906c. Read the comment docs.

Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@nstarman nstarman merged commit 8f2a32a into master Mar 3, 2021
@nstarman nstarman deleted the type_hints_and_config branch March 3, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant