Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

don’t immediately import ipython #20

Merged
merged 2 commits into from
Dec 14, 2020
Merged

don’t immediately import ipython #20

merged 2 commits into from
Dec 14, 2020

Conversation

nstarman
Copy link
Owner

@nstarman nstarman commented Dec 14, 2020

Description

the ipython sub-package should not be imported immediately. Not all code is run in the ipython kernel and it's not necessary to load this module in that case.

Now utilipy.ipython is imported by

from utilipy import ipython

PR Checklist

  • Check out the contributing guidelines and code of conduct
  • Check out the contributing workflow ( for a practical example click here )
  • Give a detailed description of the PR above.
  • Document changes in the CHANGES.rst file. See existing changelog for examples.
  • Add tests, if applicable, to ensure code coverage never decreases.
  • Make sure the docs are up to date, if applicable, particularly the docstrings and RST files in docs folder.
  • Ensure linear history by rebasing, when requested by the maintainer.

Signed-off-by: Nathaniel Starkman <nstarkman@protonmail.com>
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #20 (fbcab50) into master (47affaf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   71.13%   71.13%           
=======================================
  Files          48       48           
  Lines        2207     2207           
=======================================
  Hits         1570     1570           
  Misses        637      637           
Impacted Files Coverage Δ
utilipy/__init__.py 50.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47affaf...fbcab50. Read the comment docs.

@nstarman nstarman added this to the v1.1 milestone Dec 14, 2020
@nstarman nstarman self-assigned this Dec 14, 2020
Signed-off-by: Nathaniel Starkman <nstarkman@protonmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant