Skip to content
This repository has been archived by the owner on Jun 6, 2021. It is now read-only.

Not compatible with node v12 #85

Closed
ForsakenHarmony opened this issue Apr 23, 2019 · 3 comments
Closed

Not compatible with node v12 #85

ForsakenHarmony opened this issue Apr 23, 2019 · 3 comments

Comments

@ForsakenHarmony
Copy link

ForsakenHarmony commented Apr 23, 2019 •
edited 

iltorb/src/common/allocator.cc(36): warning C4146: unary minus operator applied to unsigned type, result still unsigned [iltorb/build/iltorb.vcxproj]
iltorb/src/dec/stream_decode.cc(29): error C2661: 'v8::Value::BooleanValue': no overloaded function takes 0 arguments [iltorb/build/iltorb.vcxproj]
iltorb/src/dec/stream_decode.cc(29): error C2512: 'StreamDecode::StreamDecode': no appropriate default constructor available [iltorb/build/iltorb.vcxproj]
iltorb/src/dec/stream_decode.cc(37): error C2661: 'v8::Value::ToObject': no overloaded function takes 0 arguments [iltorb/build/iltorb.vcxproj]
iltorb/src/dec/stream_decode.cc(43): error C2661: 'v8::Value::BooleanValue': no overloaded function takes 0 arguments [iltorb/build/iltorb.vcxproj]
iltorb/src/dec/stream_decode.cc(59): error C2661: 'v8::Value::BooleanValue': no overloaded function takes 0 arguments [iltorb/build/iltorb.vcxproj]
iltorb/src/enc/stream_encode.cc(14): error C2660: 'v8::Value::Int32Value': function does not take 0 arguments [iltorb/build/iltorb.vcxproj]
  harmony/.node-gyp/12.0.0/include/node/v8.h(2569): note: see declaration of 'v8::Value::Int32Value' (compiling source file ../src/enc/stream_encode.cc)
iltorb/src/enc/stream_encode.cc(20): error C2660: 'v8::Value::Int32Value': function does not take 0 arguments [iltorb/build/iltorb.vcxproj]
  harmony/.node-gyp/12.0.0/include/node/v8.h(2569): note: see declaration of 'v8::Value::Int32Value' (compiling source file ../src/enc/stream_encode.cc)
iltorb/src/enc/stream_encode.cc(26): error C2660: 'v8::Value::Int32Value': function does not take 0 arguments [iltorb/build/iltorb.vcxproj]
  harmony/.node-gyp/12.0.0/include/node/v8.h(2569): note: see declaration of 'v8::Value::Int32Value' (compiling source file ../src/enc/stream_encode.cc)
iltorb/src/enc/stream_encode.cc(32): error C2660: 'v8::Value::Int32Value': function does not take 0 arguments [iltorb/build/iltorb.vcxproj]
  harmony/.node-gyp/12.0.0/include/node/v8.h(2569): note: see declaration of 'v8::Value::Int32Value' (compiling source file ../src/enc/stream_encode.cc)
iltorb/src/enc/stream_encode.cc(38): error C2660: 'v8::Value::Int32Value': function does not take 0 arguments [iltorb/build/iltorb.vcxproj]
  harmony/.node-gyp/12.0.0/include/node/v8.h(2569): note: see declaration of 'v8::Value::Int32Value' (compiling source file ../src/enc/stream_encode.cc)
iltorb/src/enc/stream_encode.cc(44): error C2660: 'v8::Value::Int32Value': function does not take 0 arguments [iltorb/build/iltorb.vcxproj]
  harmony/.node-gyp/12.0.0/include/node/v8.h(2569): note: see declaration of 'v8::Value::Int32Value' (compiling source file ../src/enc/stream_encode.cc)
iltorb/src/enc/stream_encode.cc(50): error C2660: 'v8::Value::Int32Value': function does not take 0 arguments [iltorb/build/iltorb.vcxproj]
  harmony/.node-gyp/12.0.0/include/node/v8.h(2569): note: see declaration of 'v8::Value::Int32Value' (compiling source file ../src/enc/stream_encode.cc)
iltorb/src/enc/stream_encode.cc(56): error C2660: 'v8::Value::Int32Value': function does not take 0 arguments [iltorb/build/iltorb.vcxproj]
  harmony/.node-gyp/12.0.0/include/node/v8.h(2569): note: see declaration of 'v8::Value::Int32Value' (compiling source file ../src/enc/stream_encode.cc)
iltorb/src/enc/stream_encode.cc(62): error C2660: 'v8::Value::Int32Value': function does not take 0 arguments [iltorb/build/iltorb.vcxproj]
  harmony/.node-gyp/12.0.0/include/node/v8.h(2569): note: see declaration of 'v8::Value::Int32Value' (compiling source file ../src/enc/stream_encode.cc)
iltorb/src/enc/stream_encode.cc(85): error C2661: 'v8::Value::BooleanValue': no overloaded function takes 0 arguments [iltorb/build/iltorb.vcxproj]
iltorb/src/enc/stream_encode.cc(85): error C2661: 'v8::Value::ToObject': no overloaded function takes 0 arguments [iltorb/build/iltorb.vcxproj]
iltorb/src/enc/stream_encode.cc(85): error C2512: 'StreamEncode::StreamEncode': no appropriate default constructor available [iltorb/build/iltorb.vcxproj]
iltorb/src/enc/stream_encode.cc(93): error C2661: 'v8::Value::ToObject': no overloaded function takes 0 arguments [iltorb/build/iltorb.vcxproj]
iltorb/src/enc/stream_encode.cc(112): error C2661: 'v8::Value::BooleanValue': no overloaded function takes 0 arguments [iltorb/build/iltorb.vcxproj]
@nstepien
Copy link
Owner

We'll need to look into it, but since you're using Node 12, you can use the APIs that Node offers to do brotli de/compression:
https://nodejs.org/dist/latest-v12.x/docs/api/zlib.html#zlib_zlib_createbrotlicompress_options

@ForsakenHarmony
Copy link
Author

ForsakenHarmony commented Apr 23, 2019 •
edited

We're using brotli-webpack-plugin in preact-cli

@nstepien
Copy link
Owner

@ForsakenHarmony v2.4.3 has been released and should support Node 12 just fine.
Please let us know if you're running into any issues.

@ItalyPaleAle ItalyPaleAle mentioned this issue May 11, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nstepien @ForsakenHarmony