Skip to content

Commit

Permalink
additional changes for sqlalchemy 2.0
Browse files Browse the repository at this point in the history
  • Loading branch information
nstoik committed Jan 9, 2024
1 parent eb807bf commit 77f399f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
10 changes: 5 additions & 5 deletions device/tests/cli/manage/test_setup_commands.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""Test the setup_commands module."""
import pytest
from click.testing import CliRunner
from sqlalchemy import select

from fd_device.cli.manage.setup_commands import first_setup
from fd_device.database.device import Device
Expand All @@ -18,13 +19,12 @@ def test_first_setup_execution():


@pytest.mark.usefixtures("tables")
def test_first_setup_already_completed(dbsession):
def test_first_setup_already_completed():
"""Test that the cli command detects if setup already done."""

# explicitly set the first_setup to true.
system = SystemSetup()
system.first_setup = True
system.save(dbsession)
system = SystemSetup.create()
system.update(first_setup=True)

runner = CliRunner()
result = runner.invoke(first_setup, input="N\n")
Expand Down Expand Up @@ -91,7 +91,7 @@ def test_first_setup_not_standalone_db(dbsession):
input_text = "n\nY\n\n1\n\nY\n0.1\n"
result = runner.invoke(first_setup, input=input_text)

device = dbsession.query(Device).one()
device = dbsession.execute(select(Device)).scalar_one()

assert not result.exception
assert isinstance(device.device_id, str)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import random

import pytest
from sqlalchemy import select

from fd_device.cli.manage.setup_commands import initialize_device, initialize_grainbin
from fd_device.database.device import Device
Expand All @@ -25,7 +26,7 @@ def test_initialize_device_no_hardware_or_software(dbsession):

initialize_device()

device = dbsession.query(Device).first()
device = dbsession.execute(select(Device)).scalar_one_or_none()

assert device is None

Expand All @@ -42,7 +43,7 @@ def test_initialize_device(dbsession):

initialize_device()

device = dbsession.query(Device).first()
device = dbsession.execute(select(Device)).scalar_one()

assert len(device.grainbins) == number_of_grainbins

Expand All @@ -61,12 +62,12 @@ def test_initialize_device_twice(dbsession):
set_software_info("TEST_SOFTWARE_VERSION")
initialize_device()

device = dbsession.query(Device).first()
device = dbsession.execute(select(Device)).scalar_one()
assert len(device.grainbins) == number_of_grainbins

# now initialize the device again.
number_of_grainbins_second_time = random.randint(1, 10)
set_hardware_info("TEST_HARDWARE_VERSION", str(number_of_grainbins_second_time))
initialize_device()
device_second = dbsession.query(Device).first()
device_second = dbsession.execute(select(Device)).scalar_one()
assert len(device_second.grainbins) == number_of_grainbins_second_time

0 comments on commit 77f399f

Please sign in to comment.