This repository has been archived by the owner on Jan 18, 2023. It is now read-only.
Updated default values for iOS and README. #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Been so long since I've worked on this but quickly looking at the android source I don't think I ever set default values. The cardview just had it's defaults, I think Walker added the default stuff for iOS to keep it close to the default android look. Not a bad idea to set defaults for both platforms as long as it's a consistent look with the values for both android and iOS (meaning that radius =2 isn't radically different on the different platforms). |
|
It's ok, I just updated the ones for iOS, made them the same as it was in the readme file. You can updated them if you want. The PR includes the documentation for |
bradmartin
approved these changes
Jan 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps we should double check that default values are the same for Android & iOS.