Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loadFromFontIconCode() is deprecated #112

Closed
0xtotaylor opened this issue Mar 26, 2020 · 4 comments
Closed

loadFromFontIconCode() is deprecated #112

0xtotaylor opened this issue Mar 26, 2020 · 4 comments
Labels
help wanted

Comments

@0xtotaylor
Copy link

0xtotaylor commented Mar 26, 2020 •
edited
Loading

With loadFromFontIconCode() deprecated, would it be possible to update it to fromFontIconCodeSync() in fab-common.ts? This will prevent the error logs.
@romislovs
Copy link

+1

2 similar comments
@luiswill
Copy link

luiswill commented May 6, 2020 •
edited
Loading

+1

@Klunk75
Copy link

Klunk75 commented May 9, 2020

+1

@bradmartin
Copy link
Collaborator

Would accept a PR if someone wants to contribute, should be fairly straight forward. If need any help, feel free to ping me.

dosomder added a commit to dosomder/nativescript-floatingactionbutton that referenced this issue May 22, 2020
@dosomder
Use fromFontIconCodeSync instead of deprecated loadFromFontIconCode
eb5b4dc 
Fixes nstudio#112
bradmartin added a commit that referenced this issue May 28, 2020
@bradmartin
Merge pull request #115 from dosomder/master
2374a1e 
Fix #104 and #112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bradmartin @romislovs @luiswill @Klunk75 @0xtotaylor