Skip to content
This repository has been archived by the owner on Dec 19, 2021. It is now read-only.

Fixing Android crash #18 #19

Merged
merged 2 commits into from Jan 8, 2020
Merged

Fixing Android crash #18 #19

merged 2 commits into from Jan 8, 2020

Conversation

kefahB
Copy link
Contributor

@kefahB kefahB commented Jan 8, 2020

Hi,

I have fixing crash on android related with #18

it would seem that a simple settimeout resolve the issue !

Tested on Samsung Galaxy with API 29 and another android with the API 23 and it work as expected.

Copy link
Collaborator

@bradmartin bradmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be setTimeout and not settimeout() just for consistency and to avoid any issues might be good to keep the casing is all :)

I'll merge this soon. Thanks

@kefahB
Copy link
Contributor Author

kefahB commented Jan 8, 2020

Sorry about that ^^ .. I do update

@bradmartin bradmartin merged commit ce5e383 into nstudio:master Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants