Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo): Fix build issues #31

Merged
merged 4 commits into from
Apr 10, 2021
Merged

Conversation

Logikgate
Copy link
Contributor

Demo build issues

  1. Input-mask's PodFile was forcing all pods to be compiled with swift 4.0 but camera-plus requires swift 4.2.
  2. app.demo.clean and just running npm i manually within the demo folder was failing with this error:
    Screen Shot 2021-04-08 at 2 34 38 PM
  3. The demo file for camera-plus had type errors in it introduced by the merge of pull request Updates camera-plus聽#23

Fixes

  1. Modified input-mask's PodFile to only affect the InputMask pod.
  2. Changed the demo's devDependency of typescript to pin it to ~4.0.3 instead of pulling from the parent node_modules. I'm unsure why this was necessary though, if you have any idea how to make the relative path work please let me know 馃榾
  3. Modified the demo file for camera-plus to fix the type errors.

@Logikgate Logikgate mentioned this pull request Apr 8, 2021
@NathanWalker NathanWalker merged commit 75fa8cc into nstudio:master Apr 10, 2021
@NathanWalker
Copy link
Member

nativescript-input-mask published with this fix in 0.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants